fix(scrapy): dump pydantic models in JSON mode when serializing requests#961
Merged
Conversation
A pydantic model in `meta`/`cb_kwargs` with a non-JSON-native field (`datetime`, `UUID`, `HttpUrl`) failed `json.dumps` and the request was dropped, contradicting the v4 upgrade guide. Also fixes the PyPI Release Notes URL (pointed at the v2 guide) and stale Python 3.10 claims in the docs.
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
==========================================
- Coverage 90.00% 89.83% -0.18%
==========================================
Files 49 49
Lines 3053 3090 +37
==========================================
+ Hits 2748 2776 +28
- Misses 305 314 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pijukatel
reviewed
Jun 12, 2026
github-actions
Bot
added
the
tested
Pijukatel
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pydantic models in a Scrapy request's
meta/cb_kwargswere dumped in python mode, so any model with a non-JSON-native field (datetime,UUID,HttpUrl, ...) failedjson.dumpsand the request was dropped. The v4 upgrade guide promises such models keep working.model_dump(mode='json', by_alias=True).except (TypeError, ValueError)to cover pydantic'sPydanticSerializationError.